Hey i was just wondering what i could improve on this bit of code, to make it look less clunky, I haven't coded in nearly a year so I'm a bit retarded at the moment.

 

Hey i was just wondering what i could improve on this bit of code, to make it look less clunky, I haven't coded in nearly a year so I'm a bit retarded at the moment.

 

 

Well, to be honest... A lot.

 

If that's the default API for here, I suggest you write your own so that it's cleaner. 

 

ctx.getScript().sleep(MethodProvider.random(500, 1000));

 

Just looks terrible.

Well, to be honest... A lot.

 

If that's the default API for here, I suggest you write your own so that it's cleaner. 

ctx.getScript().sleep(MethodProvider.random(500, 1000));

Just looks terrible.

 

For one, there is nothing wrong with the way he's calling sleep using Script and MethodProvider being as you need to call that since it's a static reference. Using built functions in not terrible, unless they are not stable or is nonfunctional.

 

Also if you want to criticize someone work, you then need to provided the correct way of doing things, and not just an ignorant "Just looks terrible.".

It may be one of the most poorly written bots.  But it has a huge market for scripts. As for the knowledge you have I would say is very little. 

 

Well then you clearly don't know me.

For one, there is nothing wrong with the way he's calling sleep using Script and MethodProvider being as you need to call that since it's a static reference. Using built functions in not terrible, unless they are not stable or is nonfunctional.

 

Also if you want to criticize someone work, you then need to provided the correct way of doing things, and not just an ignorant "Just looks terrible.".

+1

 

Well then you clearly don't know me.

Sorry Mr/Mrs pop star!

 

You was some novice in programming, and I bet you asked for constructive criticism.

 

This is how novice programmers learn! Act maturely pl0x.

+1

Sorry Mr/Mrs pop star!

You was some novice in programming, and I bet you asked for constructive criticism.

This is how novice programmers learn! Act maturely pl0x.

not sure if serious or trolling

not sure if serious or trolling

 

;)

+1

 

Sorry Mr/Mrs pop star!

 

You was some novice in programming, and I bet you asked for constructive criticism.

 

This is how novice programmers learn! Act maturely pl0x.

 

The only reason I'm even commenting on this is because the guy who made this thread forked my github.

 

 

https://github.com/MobbyGFX/OSBot/blob/master/OSBot/src/org/solace/scripts/TestScript.java