As Maxi mentioned here, it is always better to use names. I was wondering if it was possible to add the following methods:

 

Bank

contains(java.lang.String... names)
getAmount(java.lang.String... names)

Inventory

getAmount(java.lang.String... names)
isEmptyExcept(java.lang.String... names) 

I am sure there are others, but these are the ones that I noticed when I was trying to find a similar version.

Edited June 11, 201312 yr by BotRs123

woah what's with the naming

just contains(String name)

woah what's with the naming

just contains(String name)

That has been the naming for MethodsProvider, so I just went with it.

Strings are slower, f that xd

Strings are slower, f that xd

I only requested this because of what Maxi said. Now I am debating to change some of the scripts back to using ints instead.

I see only one point in adding into the API.

But, i think it better for the script writer to make there own. Those method take less then 1 min to make each.

Strings are a lot slower but a lot more reliable for stability.  Because if Jagex decides to change some ids it won't affect the scripts who use Strings.

I didn't know Jagex changes Id's of items

public Item nameContains(String name) {
        for (Item item : client.getInventory().getItems()) {
            if (item.getName().contains(name)) {
                return item;

            }
        }
        return null;
    }

Strings are slower, f that xd

I haven't checked for myself, but in the update to revision 16 of Oldschool RS there were id changes, this makes names more accurate.

public Item nameContains(String name) {

        for (Item item : client.getInventory().getItems()) {

            if (item.getName().contains(name)) {

                return item;

            }

        }

        return null;

    }

final

 

for Bank.contains

just use a filter that accepts the given names.

Edited June 13, 201312 yr by Rawr