Deck

For people tanning I was told 2.2 works better for tanning. I just haven't had much time to work on this recently. I'll try and work on it some more soon. I started rewriting the whole structure of the code and just transferring the working methods over to it, but just haven't had time to transfer and test it all yet. This was my first script besides a simple High Alcher and the design I went for with this one just isn't good for these scripts. It got me to 99 crafting but just doesn't last for long periods of time. Hopefully the new layout will be more stable, its working nice with my new private script, so hope it will with this one also.

Has that exact error happened multiple times? I have been looking through the code and haven't figured out yet how it is reaching that line to throw the null pointer in the bank, but it makes complete sense why that error is happening if its trying to call that line from the bank. It is also supposed to check that your inventory is correct before closing the bank and continuing along with other checks before that line, so either I have something wrong that i'm missing in my checks or something weird just happened to let it through to that line. The way it is done right now it assumes that nothing was done besides something it tried to do, been trying to get it running stable before adding to much, so if you try and run it to the bank or close a menu for it, then it may get confused.

Redid most of the Jewelry crafter. I did the last 300 ruby's I had left and the only problem I had was if the script is paused and tries to continue after all the jewelry is made, it will continue to try and make more, but I forced this to happen by pausing the script to see what would happen in that case, so it should be very rare that this will happen. I will change the tanner to use the same design as the jewelry crafter if the jewelry crafter is better now.

Did some changes to the tanner which will maybe stop the getting stuck while walking. I will try and change the Jewelry crafter tomorrow. I have been working on some stuff with my new script that I think will help this one.

Thank you, least it is working for someone. I run at least an hour test on stuff before I upload but then people say it doesn't work for them, so I am working on redoing most of it at the moment. I'm assuming that most of the problems are because this is my first script that uses walking and I put to much stuff into one, which is why I am redoing most of it to spread the code out some. I already got 99 crafting from making dragonhide bodies off this so I know that part is flawless for me, but the jewelry still can use some more work. After the next few days I will have more time to work on this stuff again. For the people having trouble downloading with Mega I added a second link with another file host.

Thanks for the details y'all have been posting. I have been busy with family in town. From what it seems is the crafting leather and cutting gems aren't getting to many bugs. The tanning and jewelry crafting are having problems. I will just have to look at changing how I do walking completely since what I have been doing apparently doesn't work for y'all. It may be a few days before I can make much progress, but those detailed reports help a lot, so I have a list of stuff to check for.

I haven't fully got walking figured out with this client. It just randomly stops half way to a location sometimes. I did add a check to jewelry crafter so it should recall the walk method before using the furnace if it gets stuck, but I can't confirm this yet. It doesn't check for people closing the door, but that rarely happens. I am planing on adding that tho, but don't want to just put something in that could mess up walking, since it is buggy enough, till I know it will work. The withdrawing bugs will hopefully get fixed when I cleanup that section of the code, its kinda a mess right now. I am working on cleaning up and shortening the code now, so that it will be easier to edit.

Providing details of the problem over complaining will lead to things getting fixed faster, but thank you for at least letting me know what you were crafting and some info on what it was doing, that helped me find the problem by just looking at the code. I think I see why the null pointer is being thrown and I am fixing it now. Edit: Normal gold jewelry should be fixed now in V3.1. A check I had added during testing jewelry with gems messed up the regular gold. There is still some slightly buggy stuff, but it should be working again. Thanks for the proggy:) looks like the gem cutting is working well. Just need to speedup its reaction time now that it works.

Added Jewelry crafting. Tried to fix the problem with people saying that the wrong stuff was getting deposited by writing my own depositAllExcept method. I can't really tell if this changed anything since I didn't have the problem before. Now i'm just going to be cleaning it up. It doesn't check to see when you are out of materials to end, so that will probably be the next thing I add.

I wish that would happen to me so I could find the problem. I did another few thousand green bodies yesterday with no problem. I will maybe just put the method to withdraw thread and needle back in or I might just get rid of the deposit all except and write my own.

Added Gem cutting and fixed the skill checking anti-ban to check the crafting skill instead of magic.

Yea, next will be cuttings gems which I would assume is going to use a lot of the same methods from the leather crafter, but the jewelry will probably take me a little longer, since I will have to deal with walking and multiple materials. Gold jewelry is probably about all it will have because I don't see much other stuff that would be made in bulk.

That is weird I will try to think of something that could cause this. I wrote my own closeBank method that seems to be more reliable then the one in the API, not sure if there is a problem with it, but I got better performance in this script without it. The only thing I could see that would maybe cause a problem would be if the isOpen() API bank method. Do you have the most recent client? I don't know right now what could cause this since I have 2-3 checks for the bank before it even tries to interact with needle or thread.

Are you using the version 2.1, which is the current link. I know I had this problem with all the previous I had, but I ran the current one on about 5k dragonhide bodies yesterday without this happening.

With how new me and this script are, I haven't considered this. If people would prefer that then I would have no problem doing this eventually, but I haven't even gotten much feedback from people on how this works for them, so to me that makes me think not to many people are using this right now.

Redid the tanner. The new version does the setup with a new JFrame instead of the onscreen one I had, which will make it easier to add to. Now the tanner and all soft leather, hard leather, and dragon leather crafts should be working.

Just posted a slightly updated version. There was a spelling mistake on cowhides that should be fixed now and a few other minor changes that should make it a little smoother.

Deck Crafter and Tanner Version: 3.3 I feel like I now have the main function of this script done. It is time to just cleanup the little bugs and things. All tests were performed at the Al Kharid bank, but I would assume leather crafts and gem cutting works at all "Bank booths". Tanning and Jewelry making will need to be done in Al Kharid for now. Progress: -Tan most hides Working besides snakeskin, but I wouldn't call it flawless yet. -Craft most leather Crafts all Soft leather, Hard leather bodies, Dragonhide leather crafts. -Craft most jewelry Crafts rings, amulets, necklaces, and bracelets for gold and the following gems, sapphire, emerald, ruby, diamond, dragonstone. It does not string amulets right now. -Cut most gems Cuts Sapphire, Emerald, Ruby, Diamond, Dragonstone -Anti-ban There is a few simple things it will do but not much yet. I don't use anti-ban often so this will just be slowly completed as I progress the other parts of the script. Let me know any bugs or adjustment that should be made. I recommend checking up on the script every once in a while since it isn't flawless yet. My longest run so far, since I don't like to bot for to long. I'll put the status on the paint later. Just wanted to finish the script function first, since that is just a visual thing mainly. Bugs: -Repeats actions sometimes but this doesn't effect the process it just slows it down a bit because it may open the bank twice or click tiles in the bank again after it is already there. This will become less common I hope as I clean up my code. -Not really a bug since I didn't even put it in, but when tanning or crafting jewelry, it will not open the door if someone closes it. This hardly ever happens tho. I can't fix this until I redo how I walk there and back. -Doesn't check to see if you are done, so if you run out of materials it may just start throwing errors till I add a check for that. NOTES: **If tanning start with money in your inventory, I purposely did not put a way for the script to get money out for you since I did not want to be blamed for taking to much money out and the character dieing and loosing it. **If Crafting leather start with Thread and needle in your inventory. I may end up adding this back in to get it out for you, but I figured that's just another thing that could cause bugs. **If cutting Gems start with Chisel. **If crafting jewelry start with the mould in your inventory. **Make sure the items being used do not have to be scrolled up to get to. I am using the clients withdraw method which will not scroll up, only down. So try and keep everything on the same line horizontally for now. Download Version 3.3: http://up.ht/13WX6QA Version 3.2: http://up.ht/12lohzq Version 3.1: https://mega.co.nz/#!VBtkCAqL!LTHktTcDW6I6yxefJeLQqQkTWUgKeRucOmzIhAJ-Qyc Alternate download http://up.ht/12eFomy